Improve JSKit diagnostics for use-after-free of JSClosure #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kateinoigakukun
force-pushed
the
katei/closure-uaf-diags
branch
from
2c86c93 to
c7a6669
Compare
|
Time Change: +217ms (1%) Total Time: 17,357ms View Unchanged
|
To mitigate the debugging difficulties, JSKit should provide more information in diagnostics.
kateinoigakukun
force-pushed
the
katei/closure-uaf-diags
branch
from
c7a6669 to
d2556b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current JSKit’s diagnostics for use-after-free of JSClosure is unclear for developers to find which JSClosure is used.
To mitigate the debugging difficulties, JSKit should provide more information in diagnostics for use-after-free of JSClosure
Before
After